feat(bench): adopt node:bench instead of own runner - #170
Conversation
|
I don't know about @RafaelGSS but I'm a strong proponent of supporting all of the LTS versions at least. Big projects have lots of problems and "performance" and "keeping up with the NodeJS release tempo" seem to cohabit rather more often than they don't. I'd say this maybe rates an Issue, but for a much later release. |
|
@jdmarshall yeah, this was more a POC to check if the node:bench API surface is enough to be used by any lib This will need to be merged/released out of experimental to be able to migrate this lib to node:bench, so it will take some time At the same time, the main purpose of this lib was to be introduced inside Node.js, because they are going in a different direction than we initially thought, then creating a breaking-change release forcing users to send --experimental-bench is not a big issue |
|
Right now it seems to be failing the tests and the smoke tests. Is that bookkeeping issues or a major disconnect, would you say? |
The node:bench is not released yet, it will fail the current workflows I tested with a local build of the new node:bench and most of the features were working fine, the diff comparison between v1/v2 was not that large, so most of the features works with new runner |
Just an experiment to adopt the node:bench introduced at nodejs/node#65606
Comparison using nodejs-bench-operations: bench-node-v1-v2-comparison.md